Add new backend system support to AWS catalog provider #1708
+1,236
−576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 1, 2024 01:33
- Updated installation instructions - Aligned configuration options with `@backstage/catalog-backend-module-aws` - Removed deprecated roleArn - Added pre account scheduling support - Updated tests to leverage Mockservices
added 2 commits
November 1, 2024 08:06
Xantier
reviewed
Nov 1, 2024
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@roadiehq/catalog-backend-module-aws': minor | |||
There was a problem hiding this comment.
Thanks for taking this on! I haven't looked at the rest of modifications yet but this looks like a breaking change so let's make it major.
There was a problem hiding this comment.
Hello @Xantier
I'm working to manage backward compatiblity right now, better to turn this PR as draft.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the new backend system
@backstage/catalog-backend-module-awsand@backstage/integration-aws-nodeDynamicAccountConfigas it is already supported by@backstage/integration-aws-node✔️ Checklist
yarn changesetin the root)